Deprecate QueryState::for_each_unchecked#10815
Merged
james7132 merged 1 commit intobevyengine:mainfrom Dec 1, 2023
Merged
Conversation
Contributor
Author
|
The PR in question hasn't been merged yet, so the changes to |
alice-i-cecile
approved these changes
Nov 30, 2023
alice-i-cecile
added
A-ECS
Member
|
Thank you! I'm going to wait to merge this until the linked PR gets in. |
james7132
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Resolves Issue #10772.
Solution
Added the deprecated warning for QueryState::for_each_unchecked, as noted in the comments of PR #6773.
Followed the wording in the deprecation messages for
for_eachandfor_each_mut