Add table showing complexity of methods for Input#10126
Merged
james7132 merged 2 commits intobevyengine:mainfrom Mar 10, 2024
Merged
Add table showing complexity of methods for Input#10126james7132 merged 2 commits intobevyengine:mainfrom
james7132 merged 2 commits intobevyengine:mainfrom
Conversation
Contributor
Author
|
I've added information on all methods, hope this is ok. I've tried analyzing the source and I've also used the std::collections doc on performance also as a reference. I'm not completely sure on the values for just_pressed/just_released/pressed, which all have a call to |
alice-i-cecile
added
C-Docs
alice-i-cecile
approved these changes
Oct 16, 2023
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Nits on the wording, but nothing blocking. All of the listed time complexities appear correct to me.
ShadowMitia
force-pushed
the
doc-input-complexity
branch
from
ad76aec to
a028fef
Compare
james7132
reviewed
Nov 26, 2023
mockersf
reviewed
Dec 16, 2023
ShadowMitia
force-pushed
the
doc-input-complexity
branch
from
a028fef to
cd5dc23
Compare
ShadowMitia
force-pushed
the
doc-input-complexity
branch
from
cd5dc23 to
b6781ad
Compare
Contributor
Author
|
Updated with all suggestions and rebased on latest changes. |
james7132
approved these changes
Mar 10, 2024
james7132
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #10106
Adds a table showing computational complexity, as seen for Query (and similar to std::collections docs).
Solution
Add the complexity table
Changelog