-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Make MAX_DIRECTIONAL_LIGHTS a runtime value #8992
Copy link
Copy link
Open
Labels
A-RenderingDrawing game state to the screenDrawing game state to the screenC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Description
What problem does this solve or what need does it fill?
Currently MAX_DIRECTIONAL_LIGHTS is const, which prevents us from setting it to platform-specific (detected at runtime) values. For example, we need to set it to 1 for Adreno GPUs on WebGL. Currently, we are hard coding the value to 1 on WebGL for all GPUs, which is unnecessary.
What solution would you like?
Make it a dynamic value set and read at runtime.
See #8505 for more information.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-RenderingDrawing game state to the screenDrawing game state to the screenC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!