Skip to content

insert_resource_by_id doesnt talk about Sendness #6278

@BoxyUwU

Description

@BoxyUwU

World::insert_resource_by_id doesn't talk talk about whether type implements Send. It should either be part of safety invariants that the type implements Send, or if it implements !Send we're on the main thread. Or alternatively document a panic when called from not main thread with a !Send type (although I don't currently see a call to validate_non_send_access anywhere so I assume this is UB rn but it would be good for someone to check this)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorC-DocsAn addition or correction to our documentationP-UnsoundA bug that results in undefined compiler behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions