-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Expose rodio's Source and Sample trait in bevy_audio #5876
Copy link
Copy link
Closed
Labels
A-AudioSounds playback and modificationSounds playback and modificationC-FeatureA new feature, making something new possibleA new feature, making something new possibleD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with Bevy
Description
What problem does this solve or what need does it fill?
In bevy_audio, Decodable::Decoder requires rodio::source::Source and Decodable::DecoderItem requires rodio::Sample, which in turn, requires cpal::Sample.
Therefore, users who want to define their own Decodable types must manually import rodio and cpal.
What solution would you like?
- pub use
rodio::source::Source,rodio::Sample, andcpal::Sample.
What alternative(s) have you considered?
- Just make the users manually import the required dependencies. This will cause problems when the user wants to use a different version of rodio and cpal for other purposes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-AudioSounds playback and modificationSounds playback and modificationC-FeatureA new feature, making something new possibleA new feature, making something new possibleD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with Bevy