-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Improve change detection warning message #3071
Copy link
Copy link
Closed
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-DocsAn addition or correction to our documentationAn addition or correction to our documentationC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to use
Description
How can Bevy's documentation be improved?
WARN bevy_ecs::system::system: Too many intervening systems have run since the last time System 'doesntmatterthename' was last run; it may fail to detect changes.
This error message was actually hit by a user after they left a game running overnight.
This caused a large number of warnings, and the user was left confused.
We should:
- Move this warning to be in
debugonly. - More clearly communicated that this is only relevant for
Changed,Addedand the.is_changedand.is_addedmethods. - More clearly communicate that this is working as intended.
- State the amount of intervening systems that are needed before this will occur.
- Consider some cooldown between spamming the error message again for the same system.
If this is a regular occurence, we should probably swap change-detection to be opt-in / opt-out and move to a u64.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-DocsAn addition or correction to our documentationAn addition or correction to our documentationC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to use