-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Image::from_buffer's public signature changes if debug assertions are enabled #17891
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-RenderingDrawing game state to the screenDrawing game state to the screenC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Description
Stumbled on this review comment that came a bit too late after a merge.
This is a public API, so this will break bevy plugins using it if the "wrong" build configuration is enabled by the user.
tracingallows attaching this information to aSpaninstead, which is a better way to do this (thewarn_once!will include the span's fields).Originally posted by @SludgePhD in #11767 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-RenderingDrawing game state to the screenDrawing game state to the screenC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon