-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Input name is too generic #10853
Copy link
Copy link
Closed
Labels
A-InputPlayer input via keyboard, mouse, gamepad, and morePlayer input via keyboard, mouse, gamepad, and moreC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeM-Migration-GuideA breaking change to Bevy's public API that needs to be noted in a migration guideA breaking change to Bevy's public API that needs to be noted in a migration guide
Metadata
Metadata
Assignees
Labels
A-InputPlayer input via keyboard, mouse, gamepad, and morePlayer input via keyboard, mouse, gamepad, and moreC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeM-Migration-GuideA breaking change to Bevy's public API that needs to be noted in a migration guideA breaking change to Bevy's public API that needs to be noted in a migration guide
bevy_inputcontains a struct calledInputwhich refers to any kind of "pressable input". The problem is thatInputis too generic, since there are other kinds of input like axis input, that do not fit into there, misleading users that have not yet read the documentation.Inputshould be renamed to something more specific.This may have the drawback of a longer name, but personally I don't mind since it's not a thing that's used everywhere, so it's worth it to be more specific IMO.