Remove unnecessary Default impl of HandleType (#7472)

MinerSebas · MinerSebas · commit 1a18ab34c41a · 2023-02-02T15:09:06.000Z
# Objective

- Resolve a Fixme to remove the `Default` impl for `HandleType`, once Reflection no longer requires it.
- Presumebly this Comment was made before the `FromReflect` Derive used the `#[reflect(Default)]`, to substitute for the requirment that a ignored field has a `Default`.

## Solution

- Just remove the `Default` derive and comment.
diff --git a/crates/bevy_asset/src/handle.rs b/crates/bevy_asset/src/handle.rs
@@ -116,10 +116,7 @@ where
     marker: PhantomData<fn() -> T>,
 }
 
-// FIXME: Default is only needed because `Handle`'s field `handle_type` is currently ignored for reflection
-#[derive(Default)]
 enum HandleType {
-    #[default]
     Weak,
     Strong(Sender<RefChange>),
 }

Original file line number	Diff line number	Diff line change
`@@ -116,10 +116,7 @@ where`
`116`	`116`	`marker: PhantomData<fn() -> T>,`
`117`	`117`	`}`
`118`	`118`
`119`		-// FIXME: Default is only needed because `Handle`'s field `handle_type` is currently ignored for reflection
`120`		`-#[derive(Default)]`
`121`	`119`	`enum HandleType {`
`122`		`- #[default]`
`123`	`120`	`Weak,`
`124`	`121`	`Strong(Sender<RefChange>),`
`125`	`122`	`}`