Fix expansion for i3lock "screen" argument#423
Merged
SebTM merged 2 commits intobetterlockscreen:nextfrom Jun 28, 2024
Merged
Conversation
"screen" is never defined so the expansion always fails. The expanded form would have also passed an "-i" argument again so no image would have been loaded.
Collaborator
|
Will be considered with a potential fix for: #422 (comment) either someone creates a MR or I will do it when I have some free time but it's not high priority on my list. I'm still hoping for someone willing to take-over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#411 introduced a regression where the
--displayargument is never passed properly to i3lock's--screen/-Sargument.screenis never defined so the expansion always fails. The expanded form would have also passed an-iargument again so no image would have been loaded.How Has This Been Tested?
Ran shellcheck and ran
betterlockscreenwith--display 1and again with--display 2.Checklist: