Skip to content

fix(i18n): give Portuguese Crowdin exports distinct paths - #978

Merged
boidushya merged 2 commits into
better-lyrics:masterfrom
snowyukitty:fix/portuguese-locale-exports
Oct 7, 2026
Merged

boidushya merged 2 commits into
better-lyrics:masterfrom
snowyukitty:fix/portuguese-locale-exports

Conversation

@snowyukitty

Copy link
Copy Markdown

Description

Both Portuguese languages resolve %two_letters_code% to pt, so one Crowdin export overwrites the other. Add pt-PT: pt_PT and pt-BR: pt_BR alongside the existing Chinese mappings.

This changes only the export configuration. Checked-in catalogs, generated locale codes and saved UI-language settings are unchanged. Removing _locales/pt and handling saved pt settings require a separate manual follow-up when the new catalogs are reviewed.

In the latest Git-exported snapshots, 614 of 633 Portuguese messages match Brazilian Portuguese, and the other 19 are English. None of those differing messages is a distinct Portuguese translation. This implements the two-language mapping option in #962; removing pt-PT from the Crowdin project remains the maintainer's alternative if only one language is wanted.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Related Issue

Refs #962.

Validation

On Node.js 22.23.1 in a network-isolated Linux container:

  • Parsed the YAML with the transitively installed yaml package: the Portuguese destinations differ in both sync orders, and existing mappings/configuration remain unchanged. This is a local configuration check; a live Crowdin sync was not run.
  • npm run lint
  • npm run typecheck
  • npm run selfcheck: all 53 checks passed.
  • npm run build: Chrome, Edge and Firefox builds passed.

Checklist

  • I have performed a self-review of my code.
  • Product update: Portuguese Crowdin exports use independent destinations.

@boidushya boidushya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@all-contributors pls add @snowyukitty for code

@boidushya
boidushya merged commit f2d4181 into better-lyrics:master Oct 7, 2026
4 checks passed
@boidushya

Copy link
Copy Markdown
Member

@all-contributors please add @snowyukitty for code

@allcontributors

Copy link
Copy Markdown
Contributor

@boidushya

I've put up a pull request to add @snowyukitty! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants