Repository navigation
docs(builder): fix layout overflow on smaller screens - #5752
Conversation
Co-Authored-by: EvanGourmaud <[email protected]>
|
@bbabou is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
better-auth
@better-auth/cli
@better-auth/core
@better-auth/expo
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR adds vertical scrolling capability to the main content container in the Builder dialog component.
- Adds
overflow-y-scrollclass to the parent flex container inside the DialogContent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </DialogHeader> | ||
|
|
||
| <div className="flex gap-4 md:gap-12 flex-col md:flex-row items-center md:items-start"> | ||
| <div className="overflow-y-scroll no-scrollbar flex gap-4 md:gap-12 flex-col md:flex-row items-center md:items-start"> |
There was a problem hiding this comment.
Adding overflow-y-scroll to the parent div creates nested scrollable containers (the child div on line 273 also has overflow-scroll). This can lead to confusing scroll behavior and accessibility issues. Consider whether the parent needs scrolling given that children already have fixed heights with their own scroll containers, or consolidate the scrolling logic to avoid nesting.
| <div className="overflow-y-scroll no-scrollbar flex gap-4 md:gap-12 flex-col md:flex-row items-center md:items-start"> | |
| <div className="no-scrollbar flex gap-4 md:gap-12 flex-col md:flex-row items-center md:items-start"> |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
✅ Successfully cherry-picked to |
Co-authored-by: EvanGourmaud <[email protected]>
Fixing layout on smaller screens to be able to see the continue button
Summary by cubic
Fix layout overflow in the Builder dialog on small screens by making the content container vertically scrollable. Added overflow-y-scroll with no-scrollbar so the Continue button stays visible without showing scrollbars.
Written for commit 3af5a64. Summary will update automatically on new commits.