Repository navigation
Commit a1d0076
fix: allow the fetch_update deprecation the MSRV cannot adopt yet
Rust Lints (fmt, clippy) has been red on this branch since Rust 1.99.0 reached
the runner images, on a line no commit here touched:
error: use of deprecated method `Atomic::<u64>::fetch_update`:
renamed to `try_update` for consistency
--> src/core/turn_order.rs:13:10
The line is byte-identical at the branch point ae262b9. The cause is a
floating toolchain: no rust-toolchain.toml, `toolchain: stable` in
.github/actions/setup/action.yml, and `-D warnings` in ci.yml. ci.yml does not
run on pushes to mega/absorb-all, so this PR is the first CI run ever to lint
that branch's Rust and it surfaced a failure that was already sitting there.
The rename clippy suggests is not available to this crate. try_update is stable
only from 1.95.0, while src-tauri/Cargo.toml declares rust-version = "1.89.0"
and engineering/rust-toolchain.md:69-70 records the vendored sandbox toolchain
as 1.89.0 to match, as is [email protected]'s own rust-version. Renaming would
break the declared MSRV, break the vendored toolchain agents fetch in blocked
sandboxes, and be rejected by clippy's own incompatible_msrv lint. It trades a
deprecation error for a compile error on 1.89 through 1.94.
So the attribute goes on the one function that needs it, scoped to that
function rather than the module or the crate, with the removal condition in the
doc comment. In std, fetch_update is an alias whose body is
self.try_update(set_order, fetch_order, f), so the two are semantically
identical and behaviour does not change. This is what sub-1.95 projects did
upstream: valkey-glide#7253, apache/datafusion-comet#6507,
cheerc/agend-terminal#4, sturnus-dev/sturnus#80 and google-cloud-rust#7108 all
suppressed and deferred rather than raised their floor.
Raising the MSRV and pinning the toolchain were both considered and rejected
here. Raising it invalidates the 4 GB vendor branch that cannot be regenerated
from a sandbox. Pinning is the real root-cause fix, because a pinned toolchain
cannot drift under a -D warnings gate, but it is a repo-wide policy change that
interacts with dtolnay/rust-toolchain's explicit `toolchain: stable` and needs
someone who can run cargo to verify it. Both are recorded with their tradeoffs
in .dump/global/floating-rust-stable-breaks-ci-with-no-commit.md so the exposure
is not re-diagnosed by the next person, and so the pinning decision gets made
deliberately instead of by accident.
Co-authored-by: arena-agent <[email protected]>1 parent 5a1cb9b commit a1d0076
2 files changed
Lines changed: 107 additions & 0 deletions
File tree
- .dump/global
- src-tauri/src/core
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
11 | 22 | | |
12 | 23 | | |
13 | 24 | | |
| |||
0 commit comments