fix(tests): mark YOLO endpoint tests agent-dependent so CI doesn't false-fail

nesquena · claude · nesquena · commit 415d7f540b4c · 2026-04-27T22:22:34.000-07:00
The /api/session/yolo endpoint relies on tools.approval.{enable,disable,
is_session}_yolo from hermes-agent. routes.py falls back to no-op lambdas
when the import fails — so without the agent:
  * POST returns the input value echoed back ({"yolo_enabled": True}),
    making POST-only tests false-pass.
  * GET always returns False, breaking POST→GET round-trip tests like
    test_yolo_post_persists_within_session, which is exactly the test
    that's been failing on every CI run for over a day.

This is the same pattern used by other agent-dependent endpoints
(cron, skills) — mark the endpoint test classes with
@requires_agent_modules so they auto-skip when tools.approval is not
importable, and run normally in environments that have hermes-agent.

The 17 static-analysis tests (slash command registration, HTML elements,
CSS classes, i18n coverage) keep running everywhere — they don't need
the agent.

Local suite: 2564 passed, 7 skipped (the YOLO endpoint cluster) on
agent-less environments. Will run all 24 in CI if hermes-agent is wired,
or cleanly skip the 7 endpoint tests when not.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/tests/test_issue467_yolo_mode_toggle.py b/tests/test_issue467_yolo_mode_toggle.py
@@ -15,6 +15,8 @@
 import pathlib
 import pytest
 
+from tests.conftest import requires_agent_modules
+
 TEST_BASE = f"http://127.0.0.1:{os.environ.get('HERMES_WEBUI_TEST_PORT', '8788')}"
 
 
@@ -52,8 +54,16 @@ def _post(path, body=None, expect_ok=True):
 
 # ── Backend endpoint tests ──
 
+@requires_agent_modules
 class TestYoloEndpointGet:
-    """GET /api/session/yolo should return yolo_enabled state."""
+    """GET /api/session/yolo should return yolo_enabled state.
+
+    Agent-dependent: the endpoint reads from ``tools.approval._session_yolo``
+    in the hermes-agent process. When the agent isn't installed, routes.py
+    falls back to a no-op lambda that always returns ``False`` regardless of
+    POST state — every assertion here would either silently false-pass or
+    flake. Skip cleanly when modules aren't importable.
+    """
 
     def test_yolo_get_returns_false_by_default(self):
         """A fresh session should not have YOLO enabled."""
@@ -68,8 +78,17 @@ def test_yolo_get_requires_session_id(self):
         assert resp is not None
 
 
+@requires_agent_modules
 class TestYoloEndpointPost:
-    """POST /api/session/yolo should toggle YOLO for a session."""
+    """POST /api/session/yolo should toggle YOLO for a session.
+
+    Agent-dependent: the endpoint writes to ``tools.approval._session_yolo``
+    in the hermes-agent process. Without the agent, routes.py falls back to
+    a no-op lambda; the response shape ``{"yolo_enabled": <input>}`` echoes
+    the request body, so naive POST-only tests false-pass. The
+    ``test_yolo_post_persists_within_session`` test catches this by reading
+    state back via GET — it only succeeds when the agent is wired.
+    """
 
     def test_yolo_post_enable(self):
         """Enabling YOLO returns ok=True and yolo_enabled=True."""
