Remove the reader and rename the Go module #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While potentially useful, I currently only need the writer, and I suspect most use cases of this is similar to mine. I may revisit this in the future.
There was a problem hiding this comment.
Pull request overview
This PR refactors the repository by removing the reader functionality and renaming the Go module from textandbinaryreader to textandbinarywriter. The change simplifies the codebase to focus solely on writing functionality, as the author only needs the writer for their current use case.
Key Changes:
- Renamed the Go module and package from
textandbinaryreadertotextandbinarywriter - Removed the Reader type and all reader-specific functionality
- Moved blob header reading/writing utilities from reader.go to writer.go
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated module name to textandbinarywriter and Go version to 1.24.0 |
| README.md | Updated badge URLs to reflect the new repository name |
| reader.go | Deleted file - removed Reader type and associated functionality |
| reader_test.go | Deleted file - removed all reader tests including the TestBlobHeaderWriteAndRead test |
| writer.go | Renamed package, moved BlobMarker constant and blob header functions from reader.go |
| writer_test.go | Renamed package, updated tests to use io.Pipe directly, added new BenchmarkWriter and TestBlobHeaderWriteAndRead tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While potentially useful, I currently only need the writer, and I suspect most use cases of this is similar to mine.
I may revisit this in the future.