|
| 1 | +// Tests for the messagesAppended delta channel in the CLI agent |
| 2 | +// (issue #1675 Step 2 co-update). Pure test: real MessageProcessor, real |
| 3 | +// StateStore, real TypedEventEmitter — no module mocking. |
| 4 | + |
| 5 | +import type { ClineMessage, ExtensionMessage } from "@roo-code/types" |
| 6 | +import { MessageProcessor } from "../message-processor.js" |
| 7 | +import { StateStore } from "../state-store.js" |
| 8 | +import { TypedEventEmitter } from "../events.js" |
| 9 | + |
| 10 | +/** Minimal say:text message factory. */ |
| 11 | +function msg(ts: number, text: string, partial = false): ClineMessage { |
| 12 | + return { ts, type: "say", say: "text", text, partial, ask: undefined } as unknown as ClineMessage |
| 13 | +} |
| 14 | + |
| 15 | +/** messagesAppended ExtensionMessage factory. */ |
| 16 | +function appendedMessage(messages: ClineMessage[], messagesWatermark?: number): ExtensionMessage { |
| 17 | + return { |
| 18 | + type: "messagesAppended", |
| 19 | + messages, |
| 20 | + ...(messagesWatermark !== undefined ? { messagesWatermark } : {}), |
| 21 | + } as ExtensionMessage |
| 22 | +} |
| 23 | + |
| 24 | +describe("MessageProcessor messagesAppended (issue #1675 Step 2)", () => { |
| 25 | + let store: StateStore |
| 26 | + let emitter: TypedEventEmitter |
| 27 | + let processor: MessageProcessor |
| 28 | + |
| 29 | + beforeEach(() => { |
| 30 | + store = new StateStore() |
| 31 | + emitter = new TypedEventEmitter() |
| 32 | + processor = new MessageProcessor(store, emitter) |
| 33 | + }) |
| 34 | + |
| 35 | + test("appends a continuous batch and emits per-message events", () => { |
| 36 | + const messages: ClineMessage[] = [] |
| 37 | + emitter.on("message", (m: ClineMessage) => messages.push(m)) |
| 38 | + |
| 39 | + // Hydrate with 2 messages (count = 2), then a continuous batch of 3 |
| 40 | + // whose watermark is exactly 5. |
| 41 | + store.setMessages([msg(1, "a"), msg(2, "b")]) |
| 42 | + messages.length = 0 |
| 43 | + |
| 44 | + processor.processMessage(appendedMessage([msg(3, "c"), msg(4, "d"), msg(5, "e")], 5)) |
| 45 | + |
| 46 | + expect(store.getMessages().length).toBe(5) |
| 47 | + expect(store.getMessages().map((m) => m.text)).toEqual(["a", "b", "c", "d", "e"]) |
| 48 | + expect(messages.length).toBe(3) |
| 49 | + }) |
| 50 | + |
| 51 | + test("drops a discontinuous batch and emits stateResyncNeeded", () => { |
| 52 | + const resyncs: Array<{ held: number; watermark: number }> = [] |
| 53 | + emitter.on("stateResyncNeeded", (payload) => resyncs.push(payload as { held: number; watermark: number })) |
| 54 | + |
| 55 | + store.setMessages([msg(1, "a"), msg(2, "b")]) |
| 56 | + |
| 57 | + // Watermark 9 means messages 3..6 were lost (held 2 + batch 3 != 9). |
| 58 | + processor.processMessage(appendedMessage([msg(7, "g"), msg(8, "h"), msg(9, "i")], 9)) |
| 59 | + |
| 60 | + expect(store.getMessages().length).toBe(2) |
| 61 | + expect(resyncs.length).toBe(1) |
| 62 | + expect(resyncs[0]).toEqual({ held: 2, watermark: 9 }) |
| 63 | + }) |
| 64 | + |
| 65 | + test("treats a batch without watermark as continuous (backward compatible)", () => { |
| 66 | + store.setMessages([msg(1, "a")]) |
| 67 | + |
| 68 | + processor.processMessage(appendedMessage([msg(2, "b")])) |
| 69 | + |
| 70 | + expect(store.getMessages().length).toBe(2) |
| 71 | + }) |
| 72 | + |
| 73 | + test("an empty batch is a no-op", () => { |
| 74 | + store.setMessages([msg(1, "a")]) |
| 75 | + |
| 76 | + processor.processMessage(appendedMessage([], 1)) |
| 77 | + |
| 78 | + expect(store.getMessages().length).toBe(1) |
| 79 | + }) |
| 80 | + |
| 81 | + test("a stale post-resync batch is dropped", () => { |
| 82 | + store.setMessages([msg(1, "a"), msg(2, "b"), msg(3, "c")]) |
| 83 | + |
| 84 | + // A resync already brought the store to 3 messages; a stale batch from |
| 85 | + // before the snapshot carries a smaller watermark and must not append. |
| 86 | + processor.processMessage(appendedMessage([msg(2, "b")], 2)) |
| 87 | + |
| 88 | + const messages = store.getMessages() |
| 89 | + expect(messages.length).toBe(3) |
| 90 | + expect(messages[messages.length - 1]?.text).toBe("c") |
| 91 | + }) |
| 92 | +}) |
0 commit comments