-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Labels
Description
I wanted to capture the notes I took during our code review.
Moved
- An option to handle proposed syntax (nested import, namespace export) (moved to Configurable syntax support #100)
- Don't save setter for const exports. (moved to Don't save setter for const exports. #134)
Completed
- Check if namespace import is constant and if so the bind isn't needed and it can be const.
- Use arrow functions for module.import and
module.exports,module.import, andmodule.importSync. - The namespace object should be
Object.create(null) - The cache hash - look into mtime + path + version.
- If a module has
import/exportadd'use strict' - Align setEsModule
__esModuleproperty non-enumerable -
- Make the uniqueKey a fast property by changing the:to a__or something similar -
ShouldaddGettersthrow? Yes. -
forEachSetter(use UNDEFINED lookup)
benjamn