Skip to content

Use esprima-fb from NPM by default.#106

Merged
benjamn merged 2 commits into
masterfrom
use-esprima-fb-from-npm
Aug 15, 2014
Merged

Use esprima-fb from NPM by default.#106
benjamn merged 2 commits into
masterfrom
use-esprima-fb-from-npm

Conversation

@benjamn

@benjamn benjamn commented Aug 15, 2014

Copy link
Copy Markdown
Owner

Note that you can still use whatever parser you want by calling recast.parse with options.esprima equal to any object with a compatible .parse method: recast.parse(source, { esprima: require("your-esprima") }).

I will merge this as soon as @zpao or @jeffmo publishes the latest version of esprima-fb to NPM.

Closes #105.

Comment thread package.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to use ~ over ^ here? I know that ^ will accept different minor versions, but I forget if ~ does as well for versions greater than 1.0.0.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only because ^ isn't understood by older versions of npm (including the one that comes with node v0.8, I believe).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good point.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who cares about node v0.8 anyways? jajaja, if you're using recast, you're probably living at that edge already :)

benjamn added a commit that referenced this pull request Aug 15, 2014
Use esprima-fb from NPM by default.
@benjamn
benjamn merged commit 318515c into master Aug 15, 2014
@benjamn
benjamn deleted the use-esprima-fb-from-npm branch August 15, 2014 16:23
@benjamn

benjamn commented Aug 15, 2014

Copy link
Copy Markdown
Owner Author

@caridy

caridy commented Aug 15, 2014

Copy link
Copy Markdown

awesome! thanks @benjamn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

don't depend on esprima#harmony

3 participants