Skip to content

Add ImportExpression node type (ES2020)#365

Merged
benjamn merged 5 commits into
benjamn:masterfrom
mkubilayk:import-expression
Mar 27, 2020
Merged

Add ImportExpression node type (ES2020)#365
benjamn merged 5 commits into
benjamn:masterfrom
mkubilayk:import-expression

Conversation

@mkubilayk

@mkubilayk mkubilayk commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

ES2020 grammar has ImportExpression node type for dynamic import(). Based on ESTree spec, this PR adds support for it in ast-types.

@mkubilayk

mkubilayk commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

Hi @benjamn - I'd appreciate if we can get this in. Do you have time to take a look?

@GeeWizWow

GeeWizWow commented Mar 17, 2020 •
edited
Loading

Copy link
Copy Markdown

@benjamn Hi, any plans to merge this CL ?

benjamn
benjamn approved these changes Mar 27, 2020
View reviewed changes

@benjamn benjamn left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @mkubilayk!

I'm going to release a patch version with this change, and then a minor version after consolidating the def/es* modules into a single def/esNext module, so that we can stop worrying about the versions/years.

@benjamn
benjamn merged commit b180525 into benjamn:master Mar 27, 2020
@benjamn

benjamn commented Mar 27, 2020

Copy link
Copy Markdown
Owner

Please note that Babel already had an Import node that was used as the callee of a CallExpression to represent dynamic import(...) calls. That was changed without much discussion in estree/estree#197, which was shipped along with estree/estree#198. I must be missing some context around how changes like these get approved and shipped, but for now ast-types can just support both versions.

benjamn added a commit to benjamn/recast that referenced this pull request Mar 27, 2020
@benjamn
Add missing ImportExpression printer case.
aac6d75 
benjamn/ast-types#365 (comment)
@mkubilayk
mkubilayk deleted the import-expression branch March 30, 2020 07:38
@mkubilayk

mkubilayk commented Mar 30, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for merging this @benjamn!

@haoqunjiang haoqunjiang mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamn benjamn benjamn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkubilayk @GeeWizWow @benjamn