Add summary even when failure threshold is surpassed #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alerts are currently generated by throwing an exception. This means that all code that comes after that exception is skipped, including generating the Action summary. We can easily fix this, by generating the summary first. Longer term, we might want to reconsider the code style here. An exception should model something exceptional happening in our code. Seeing bad benchmark numbers is not exceptional. It's what this tool is supposed to handle. Closes benchmark-action#254
|
@ktrz could we get this merged? it would be a very nice quality of life fix :) |
ktrz
approved these changes
Mar 12, 2025
Member
ktrz
left a comment
ktrz
left a comment
There was a problem hiding this comment.
Thank you for submitting this change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alerts are currently generated by throwing an exception. This means that all code that comes after that exception is skipped, including generating the Action summary.
We can easily fix this, by generating the summary first.
Longer term, we might want to reconsider the code style here. An exception should model something exceptional happening in our code. Seeing bad benchmark numbers is not exceptional. It's what this tool is supposed to handle.
Closes #254