Skip to content

feat: allow to parse generic cargo bench/criterion units #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktrz merged 2 commits into from
Dec 9, 2024
Merged

feat: allow to parse generic cargo bench/criterion units #280

ktrz merged 2 commits into from
Dec 9, 2024

Conversation

@xtrm0
Copy link
Contributor

@xtrm0 xtrm0 commented Nov 27, 2024

Previously the unit 'ns/iter' was hardcoded:

test bench_fib_10 ... bench:         148.70 ns/iter (+/- 2.21)
test bench_fib_20 ... bench:      18,794.12 ns/iter (+/- 440.25)

This PR allows any unit:

test cmov ... bench:        2835 cycles/iter (+/- 14)
test cmov2 ... bench:        2845 cycles/iter (+/- 19)
test mov ... bench:        1508 cycles/iter (+/- 17)

@xtrm0 xtrm0 mentioned this pull request Nov 27, 2024
Closed
@ktrz
Copy link
Member

ktrz commented Nov 27, 2024

Thank you @xtrm0 for the contribution! I'll review the PR tomorrow

@ktrz ktrz changed the title Allow to parse generic cargo bench/criterion units feat: allow to parse generic cargo bench/criterion units Dec 9, 2024
@ktrz ktrz merged commit e3c6616 into benchmark-action:master Dec 9, 2024
27 checks passed
@ktrz
Copy link
Member

ktrz commented Sep 2, 2025

released in https://github.com/benchmark-action/github-action-benchmark/releases/tag/v1.20.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktrz ktrz ktrz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtrm0 @ktrz