Skip to content

fix: 204 ratio is NaN when previous value is 0 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktrz merged 3 commits into from
Jan 31, 2024
Merged

fix: 204 ratio is NaN when previous value is 0 #222

ktrz merged 3 commits into from
Jan 31, 2024

Conversation

@ktrz
Copy link
Member

@ktrz ktrz commented Jan 30, 2024 •
edited
Loading

  • extract getRatio function
  • print 1 when both values are 0
  • print +-∞ when divisor is 0

fixes #204

@ktrz
fix: 204 ratio is NaN when previous value is 0
afa4842 
* extract getRatio function
* print 1 when both values are 0
* print +-∞ when divisor is 0
@ktrz ktrz requested a review from ningziwen January 30, 2024 16:57
@ktrz ktrz self-assigned this Jan 30, 2024
@ktrz ktrz mentioned this pull request Jan 30, 2024
Closed
miparnisari
miparnisari approved these changes Jan 31, 2024
View reviewed changes
ningziwen
ningziwen previously approved these changes Jan 31, 2024
View reviewed changes
@ktrz ktrz merged commit e108afd into master Jan 31, 2024
@ktrz ktrz deleted the fix/204-ratio-is-nan-when-prev-value-is-zero branch January 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@miparnisari miparnisari miparnisari approved these changes

@ningziwen ningziwen ningziwen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ktrz ktrz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NaN is given as ratio when the previous value is 0

4 participants

@ktrz @miparnisari @ningziwen