Skip to content

NaN is given as ratio when the previous value is 0 #204

New issue
New issue
Closed
#222
Closed
NaN is given as ratio when the previous value is 0#204
#222
@miparnisari

Description

@miparnisari
miparnisari
opened on Nov 30, 2023
image

If a previous benchmark is 0, don't try to divide here

github-action-benchmark/src/write.ts

Lines 179 to 181 in a229668

const ratio = biggerIsBetter(curSuite.tool)
? prev.value / current.value // e.g. current=100, prev=200
: current.value / prev.value;

or here

github-action-benchmark/src/write.ts

Lines 575 to 577 in a229668

const ratio = biggerIsBetter(config.tool)
? previousBench.value / bench.value
: bench.value / previousBench.value;

or here

github-action-benchmark/src/write.ts

Lines 107 to 109 in a229668

const ratio = biggerIsBetter(curSuite.tool)
? prev.value / current.value // e.g. current=100, prev=200
: current.value / prev.value; // e.g. current=200, prev=100

(Why are there three places doing a division? 😆 )

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions