Introduce BenchmarkConfig to selectively use config in benchmark#414
Merged
Introduce BenchmarkConfig to selectively use config in benchmark#414
BenchmarkConfig to selectively use config in benchmark#414Conversation
PragTob
force-pushed
the
minimize-benchmark-data
branch
from
aeecba5 to
38eeab3
Compare
Fixes #412 - but basically the `Config` holds `inputs` and that can be a hell loat of data to send along with every benchmark. In a benchmark with 16 scenarios and huge inputs we now save ourselves copying that potentially huge data structure a whopping 16 times to our benchmarking processes for no reason whatsoever (the scenarios already hold the `input`).
PragTob
force-pushed
the
minimize-benchmark-data
branch
from
38eeab3 to
3d862b6
Compare
PragTob
added a commit
that referenced
this pull request
Dec 19, 2023
This reverts commit dfa6987. It turned out that the parallel processing wasn't the issue with memory consumption we faced but instead copying data to processes. See: * #408 * #414 * https://pragtob.wordpress.com/2023/12/18/careful-what-data-you-send-or-how-to-tank-your-performance-with-task-async/
PragTob
added a commit
that referenced
this pull request
Dec 19, 2023
This reverts commit dfa6987. It turned out that the parallel processing wasn't the issue with memory consumption we faced but instead copying data to processes. See: * #408 * #414 * https://pragtob.wordpress.com/2023/12/18/careful-what-data-you-send-or-how-to-tank-your-performance-with-task-async/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #412 - but basically the
Configholdsinputsand that can be a hell loat of data to send along with every benchmark.In a benchmark with 16 scenarios and huge inputs we now save ourselves copying that potentially huge data structure a whopping 16 times to our benchmarking processes for no reason whatsoever (the scenarios already hold the
input).