Skip to content

Explore reason behind invalid JSON response. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benbowler wants to merge 52 commits into
base: develop
Choose a base branch
from
Open

Explore reason behind invalid JSON response. #2

benbowler wants to merge 52 commits into from

Conversation

@benbowler
Copy link
Owner

@benbowler benbowler commented Aug 14, 2025

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

benbowler added 30 commits May 28, 2025 13:49
@benbowler
Bring createWaitForFetchRequestsWithDebounce helper from bug/10108-fi…
9816657 
…x-setup-gcp-no-account-no-tag-poc branch.
@benbowler
Wait for fetch requests to finish at the end of each test suite befor…
eda4697 
…e navigating to deactivate plugin.
@benbowler
Filter E2E tests to validate success faster.
a75e137
@benbowler
Add repeat run for debug.
44d221c
@benbowler
Debug single test implementation.
6e67aaa
@benbowler
Merge remote-tracking branch 'origin/develop' into infrastructure/108…
661f891 
…34-e2e-invalid-json.
@benbowler
Experiment with waitForNetworkIdle.
9e7b78b
@benbowler
Move to single test wide capture or tests.
622a321
@benbowler
Apply fix to tests/e2e/specs/user-input-questions.test.js from google…
feeffe5 
…#10905.
@benbowler
Tweaks to createWaitForFetchRequestsWithDebounce implemnetation.
97d29cc
@benbowler
Increase timeout during createWaitForFetchRequestsWithDebounce to inc…
4cbfb8e 
…rease reliability and include additional debugging.
@benbowler
Add additional resource types and debugging.
e595abe
@benbowler
Further increase timeout on waitForResponse.
e70f6fa
@benbowler
Add additional debugging and further increase timeout.
e92c3af
@benbowler
Revert to Tom's PoC for final check with beforeEach.
9270fdc
@benbowler
Move creation of waitForFetchRequests to be shared by each test.
7b925c0
@benbowler
Update test createWaitForFetchRequestsWithDebounce implementation.
7fa6894
@benbowler
Merge remote-tracking branch 'origin/develop' into infrastructure/108…
a46b1b1 
…34-e2e-invalid-json.
@benbowler
Apply test level fix.
e9ae643
@benbowler
Merge remote-tracking branch 'origin/develop' into infrastructure/108…
fdf609e 
…34-e2e-invalid-json.
@benbowler
Add enhanced request wait function with abort controller as backup.
9c856ba
@benbowler
Temporarily disable the abort controller feature to test rest of impl…
e2af94b 
…mentation avoiding the log after tests error.
@benbowler
Disable logging to prevent logging related tests error.
d1060d8
@benbowler
Further simplify and clean up the enhanced wait function.
de55113
@benbowler
Clean the wait function and add additional checks.
ad98221
@benbowler
Simplify requestID used within request tracking.
880b6d0
@benbowler
Check if requests can have the same requestID.
cb50c10
@benbowler
Remove duplicate ID check and remove unused startTime prop.
84b49dc
@benbowler
Add debug logging for timeout errors within tests/e2e/specs/user-inpu…
de8ce7d 
…t-questions.test.js.
@benbowler
Remove try/catch for user-input-questions.test.js.
a797b97
@benbowler benbowler force-pushed the debug-e2e-invalid-json-response branch 2 times, most recently from f823ee3 to 10a8ea8 Compare August 14, 2025 14:16
@github-actions
Copy link

github-actions bot commented Aug 14, 2025 •
edited
Loading

Size Change: +318 B (+0.01%)

Total Size: 2.19 MB

ℹ️ View Unchanged
Filename Size Change
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 491 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 47.3 kB 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 492 B 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 9.5 kB 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 8.99 kB 0 B
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 9.5 kB 0 B
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 8.99 kB 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.js 492 B 0 B
./dist/assets/blocks/sign-in-with-google/index.js 18.1 kB 0 B
./dist/assets/css/googlesitekit-admin-css-********************.min.css 62.1 kB 0 B
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.7 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.43 kB 0 B
./dist/assets/js/32-********************.js 2.76 kB 0 B
./dist/assets/js/33-********************.js 2.25 kB 0 B
./dist/assets/js/34-********************.js 3.64 kB 0 B
./dist/assets/js/35-********************.js 936 B 0 B
./dist/assets/js/36-********************.js 893 B 0 B
./dist/assets/js/37-********************.js 1.83 kB 0 B
./dist/assets/js/38-********************.js 3.12 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 902 B 0 B
./dist/assets/js/googlesitekit-activation-********************.js 28 kB 0 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.8 kB 0 B
./dist/assets/js/googlesitekit-adminbar-********************.js 39.5 kB 0 B
./dist/assets/js/googlesitekit-api-********************.js 10.7 kB +318 B (+3.06%)
./dist/assets/js/googlesitekit-components-********************.js 6.9 kB 0 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 2.38 kB 0 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.08 kB 0 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.05 kB 0 B
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.5 kB 0 B
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.17 kB 0 B
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.9 kB 0 B
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 61.7 kB 0 B
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 977 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 717 B 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 639 B 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.39 kB 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 4.16 kB 0 B
./dist/assets/js/googlesitekit-main-dashboard-********************.js 142 kB 0 B
./dist/assets/js/googlesitekit-metric-selection-********************.js 57.7 kB 0 B
./dist/assets/js/googlesitekit-modules-********************.js 23.8 kB 0 B
./dist/assets/js/googlesitekit-modules-ads-********************.js 54.2 kB 0 B
./dist/assets/js/googlesitekit-modules-adsense-********************.js 133 kB 0 B
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 211 kB 0 B
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 26.8 kB 0 B
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 49.8 kB 0 B
./dist/assets/js/googlesitekit-modules-search-console-********************.js 72.8 kB 0 B
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 37.1 kB 0 B
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 33.2 kB 0 B
./dist/assets/js/googlesitekit-notifications-********************.js 70.4 kB 0 B
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 138 kB 0 B
./dist/assets/js/googlesitekit-splash-********************.js 75.1 kB 0 B
./dist/assets/js/googlesitekit-user-input-********************.js 50.2 kB 0 B
./dist/assets/js/googlesitekit-vendor-********************.js 314 kB 0 B
./dist/assets/js/googlesitekit-widgets-********************.js 112 kB 0 B
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 66.6 kB 0 B
./dist/assets/js/runtime-********************.js 1.32 kB 0 B

compressed-size-action

@benbowler benbowler force-pushed the debug-e2e-invalid-json-response branch from 34fe62a to 761b66a Compare August 15, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benbowler