This repository was archived by the owner on May 18, 2023. It is now read-only.
Fix tests to not call t.Fatal from a goroutine#34
Merged
djmitche merged 1 commit intobenbjohnson:masterfrom Oct 25, 2021
Merged
Fix tests to not call t.Fatal from a goroutine#34djmitche merged 1 commit intobenbjohnson:masterfrom
djmitche merged 1 commit intobenbjohnson:masterfrom
Conversation
The "too late!" version of this call was being made *after* the corresponding test had completed, causing all manner of sadness from the testing package. This refactors the tests to just measure the duration of the various kinds of sleep, and assert that the duration is within a good range.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "too late!" version of this call was being made after the
corresponding test had completed, causing all manner of sadness from the
testing package.
This refactors the tests to just measure the duration of the various
kinds of sleep, and assert that the duration is within a good range.