-
Notifications
You must be signed in to change notification settings - Fork 115
Comparing changes
Open a pull request
base repository: benbjohnson/clock
base: v1.1.0
head repository: benbjohnson/clock
compare: v1.2.0
- 18 commits
- 3 files changed
- 6 contributors
Commits on Nov 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9d456ff - Browse repository at this point
Copy the full SHA 9d456ffView commit details -
Merge pull request #26 from narqo/patch-1
Fix typo in Ticker example
Configuration menu - View commit details
-
Copy full SHA for 4031354 - Browse repository at this point
Copy the full SHA 4031354View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0f43ae6 - Browse repository at this point
Copy the full SHA 0f43ae6View commit details
Commits on Feb 13, 2021
-
Merge pull request #28 from dcherman/master
Implement reset for mocked tickers
Configuration menu - View commit details
-
Copy full SHA for c97fc7b - Browse repository at this point
Copy the full SHA c97fc7bView commit details
Commits on Oct 20, 2021
-
Fix tests to not call t.Fatal from a goroutine
The "too late!" version of this call was being made *after* the corresponding test had completed, causing all manner of sadness from the testing package. This refactors the tests to just measure the duration of the various kinds of sleep, and assert that the duration is within a good range.
Configuration menu - View commit details
-
Copy full SHA for ae80999 - Browse repository at this point
Copy the full SHA ae80999View commit details
Commits on Oct 25, 2021
-
Merge pull request #34 from djmitche/test-fixes
Fix tests to not call t.Fatal from a goroutine
Configuration menu - View commit details
-
Copy full SHA for f7a1d13 - Browse repository at this point
Copy the full SHA f7a1d13View commit details -
This defers execution of the ticked function until after the lock has been released, allowing it to make other calls without a deadlock.
Configuration menu - View commit details
-
Copy full SHA for 0b9476f - Browse repository at this point
Copy the full SHA 0b9476fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 850609f - Browse repository at this point
Copy the full SHA 850609fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad814c - Browse repository at this point
Copy the full SHA 5ad814cView commit details -
Merge pull request #35 from djmitche/issue33
Address re-entrancy of Tick
Configuration menu - View commit details
-
Copy full SHA for f495692 - Browse repository at this point
Copy the full SHA f495692View commit details -
Merge pull request #36 from djmitche/issue30
add a Duration type alias
Configuration menu - View commit details
-
Copy full SHA for 4378ee0 - Browse repository at this point
Copy the full SHA 4378ee0View commit details -
Use channels to avoid races in tests
Using a mock for time doesn't mean races aren't important. This tries to set a good Example by using channels rather than shared variables for communication between goroutines.
Configuration menu - View commit details
-
Copy full SHA for 99d58a2 - Browse repository at this point
Copy the full SHA 99d58a2View commit details
Commits on Oct 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 47e2ce0 - Browse repository at this point
Copy the full SHA 47e2ce0View commit details
Commits on Oct 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 37a1270 - Browse repository at this point
Copy the full SHA 37a1270View commit details -
Apply suggestions from code review
Co-authored-by: Josh Soref <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb95674 - Browse repository at this point
Copy the full SHA eb95674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a12ec5 - Browse repository at this point
Copy the full SHA 0a12ec5View commit details -
Merge pull request #37 from djmitche/issue8
Use channels to avoid races in tests
Configuration menu - View commit details
-
Copy full SHA for 1ae85fe - Browse repository at this point
Copy the full SHA 1ae85feView commit details
Commits on Nov 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 26f124e - Browse repository at this point
Copy the full SHA 26f124eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.1.0...v1.2.0