Apply Beman CMake standard#74
Merged
neatudarius merged 3 commits intobemanproject:mainfrom Nov 13, 2024
Merged
Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
wusatosi
force-pushed
the
build_testing_change
branch
from
d6f60d3 to
65a4f66
Compare
neatudarius
reviewed
Nov 13, 2024
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
Would you like to also apply CMAKE.SKIP_EXAMPLES?
Member
Author
I can try. I am adding a CI check. |
neatudarius
approved these changes
Nov 13, 2024
wusatosi
changed the title
Member
Author
|
hey it was not ready :( The CI was broken! |
Member
Author
|
I will fix the CI right now. |
Merged
Member
Author
|
Still bothers me why a malformed workflow file doesn't result in a CI failure.... GitHub Action you literally cannot read the file!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update project to comply with:
Needs a new CI to check [CMAKE.SKIP_EXAMPLES]