Proper permission fix for reviewdog#69
Merged
wusatosi merged 1 commit intobemanproject:mainfrom Nov 10, 2024
Merged
Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
neatudarius
approved these changes
Nov 10, 2024
wusatosi
force-pushed
the
fix-permission
branch
from
28779a0 to
b9d30a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes the permission issue pre-commit GitHub Action was experiencing.
Turns out GitHub issues conservative permission to pull requests coming from a private fork, see: link.
To get write permission, we need to use
pull_request_targetas event trigger instead. Inpull_request_targetGitHub Actions checks out the base branch instead of the pr, so we need to manually checkout the pull request via GitHub CLI.See: https://github.com/bean-men/testing-exempler/pull/6 as an example of correct output. Note that the pr come from my private fork from
wusatosi/testing-exemplerto an org inbean-man/testing-exempler.Due to the introduced complexity, this pr also splits the
pre-commitcheck for push and pull-request into two different jobs.Closes #49 . (again).