Move Build & Test out of docker#48
Merged
camio merged 8 commits intobemanproject:mainfrom Oct 21, 2024
Merged
Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
wusatosi
commented
Oct 18, 2024
Comment on lines
-44
to
-47
| echo "image-version=$(echo $ImageVersion)" >> "$GITHUB_OUTPUT" | ||
| working-directory: . | ||
| - name: modify number of bits to use for ASLR entropy | ||
| if: ${{ steps.runner-image-version.outputs.ImageVersion }} == '20240310.1.0' |
Member
Author
There was a problem hiding this comment.
we no longer have to care about this. Current image version has well past this post.
(Also this condition was erroneous).
wusatosi
commented
Oct 18, 2024
| with: | ||
| cmakeVersion: "~3.25.0" | ||
| ninjaVersion: "^1.11.1" | ||
| - name: Print installed softwares |
Member
Author
There was a problem hiding this comment.
GitHub Image comes with Clang and GCC, we can setup specific version of them if needed in the future.
Merged
camio
approved these changes
Oct 19, 2024
Member
camio
left a comment
camio
left a comment
There was a problem hiding this comment.
I added some minor comments, but otherwise approve.
Co-authored-by: David Sankel <[email protected]>
Co-authored-by: David Sankel <[email protected]>
neatudarius
reviewed
Oct 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the build and test system in CI out of docker and refactors the CI script.
This PR is functionally the same as head (with minor improvement).
Reduce CI time from ~2 minutes down to ~45 seconds.
Based on Discussion here: https://discourse.bemanproject.org/t/should-we-use-or-remove-docker-from-beman/228
Closes #27