Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
This approach to modules implementation is based on the approach used to implement module support for Boost by Rubén Pérez (anarthal). See his documentation: https://github.com/anarthal/boost-cmake/blob/e29bc2a5bd3493d353bf597610d4b32b5a11d0dc/modules.md The basic idea is that every header is in one of three modes: - Normal mode (the user included the header, and we aren't building with modules) - In this case, the macros configure the header so its contents are the same as their pre-refactor state - included-from-interface-unit-mode - Here, we're inserting all the code from the header into an export block inside the implementation of the .cppm file, so this mode is the same as normal mode except that we ifdef out any standard library includes, or any other dependencies that the .cppm file is bringing in via module - Compatibility header mode - The project is built as a module, but the consumer still is bringing the dependency in by writing #include <{...}.hpp>. In this case the header #ifdefs out everything except a simple import beman.foo statement.
|
Coverage is 100.0% — enolan_modules3 into main. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach to modules implementation is based on the approach used to implement module support for Boost by Rubén Pérez (anarthal). See his documentation:
https://github.com/anarthal/boost-cmake/blob/e29bc2a5bd3493d353bf597610d4b32b5a11d0dc/modules.md
The basic idea is that every header is in one of three modes: