Merged
Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
ednolan
force-pushed
the
enolan_disablestatic1
branch
from
d85b096 to
40e3cc9
Compare
ednolan
changed the title
Static libraries are currently incompatible with our modules design-- not inherently so, but I just haven't done the work yet to couple them together, and deploying modules is higher priority (we have many libraries that implement modules, but to my understanding, none of our libraries need to have .cpp files currently).
ednolan
force-pushed
the
enolan_disablestatic1
branch
from
40e3cc9 to
47d4d3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static libraries are currently incompatible with our modules design--
not inherently so, but I just haven't done the work yet to couple them
together, and deploying modules is higher priority (we have many
libraries that implement modules, but to my understanding, none of our
libraries need to have .cpp files currently).