ci: raise gtest_discover_tests DISCOVERY_TIMEOUT to 60s#365
Merged
Conversation
The default 5s discovery timeout intermittently fails on the MSVC Debug runner, where launching the test binary just to enumerate tests can take longer than 5 seconds. Bump to 60s in both the exemplar tests and the cookiecutter template so generated projects inherit the fix. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
|
coverage: 100.0%. remained the same — ci/gtest-discovery-timeout into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISCOVERY_TIMEOUTforgtest_discover_testsintermittently fires on the MSVC Debug runner — discovery just runs the test binary with--gtest_list_tests, but Debug-mode MSVC builds can take longer than 5s to launch. Example failure: https://github.com/bemanproject/transform_view/actions/runs/25011381871/job/73247753008DISCOVERY_TIMEOUT 60in both the exemplar tests and the cookiecutter template so generated projects inherit the fix.Test plan
🤖 Generated with Claude Code