Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
|
coverage: 100.0%. remained the same — enolan_clang18fix1 into main |
Commit 48638ee was intended to address the unit test issues that occurred when our test images that use older versions of Clang were upgraded to libstdc++ 15, introducing incompatibilities. But among the unit tests it removed, Clang 18/C++23/libstdc++ was removed unnecessarily. This commit adjusts the CI matrix to restore that job.
ednolan
force-pushed
the
enolan_clang18fix1
branch
from
c931821 to
b88d139
Compare
ednolan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 48638ee was intended to
address the unit test issues that occurred when our test images that
use older versions of Clang were upgraded to libstdc++ 15, introducing
incompatibilities. But among the unit tests it removed, Clang
18/C++23/libstdc++ was removed unnecessarily. This commit adjusts the
CI matrix to restore that job.