Restore Compiler Explorer badge in exemplar but not cookiecutter#352
Merged
Restore Compiler Explorer badge in exemplar but not cookiecutter#352
Conversation
e064736 removed the Compiler Explorer badge from both exemplar and cookiecutter, on the logic that newly created libraries won't have godbolt links yet. However, as pointed out by #351, unlike libraries stamped out from the cookiecutter template, exemplar itself isn't a newly created library and it can include a proper Compiler Explorer link. This commit restores the Compiler Explorer link to exemplar while still omitting it from cookiecutter templates, by using the cookiecutter._generating_exemplar mechanism.
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
|
coverage: 100.0%. remained the same — enolan_restoregodbolt1 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e064736 removed the Compiler Explorer badge from both exemplar and cookiecutter, on the logic that newly created libraries won't have godbolt links yet. However, as pointed out by #351, unlike libraries stamped out from the cookiecutter template, exemplar itself isn't a newly created library and it can include a proper Compiler Explorer link. This commit restores the Compiler Explorer link to exemplar while still omitting it from cookiecutter templates, by using the cookiecutter._generating_exemplar mechanism.