Remove godbolt_link parameter from cookiecutter template#345
Merged
Conversation
Asking users to provide a compiler explorer link at the same time as they create their library for the first time creates a chicken-egg situation, given that the compiler explorer links are supposed to make use of the copies of the library that are installed into compiler explorer rather than just copypastes. This change removes the parameter; users can add it to new libraries after they've set up compiler explorer support separately.
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asking users to provide a compiler explorer link at the same time as they create their library for the first time creates a chicken-egg situation, given that the compiler explorer links are supposed to make use of the copies of the library that are installed into compiler explorer rather than just copypastes. This change removes the parameter; users can add it to new libraries after they've set up compiler explorer support separately.