Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
This commit allows cookiecutter to support creating Beman libraries that use catch2 as their unit testing library instead of gtest. It adds a new unit_test_library option to the exemplar cookiecutter parameters that can be set to either "gtest" or "catch2". It adds a new exemplar-only CI workflow, catch2_exemplar_test.yml, that smoke tests that the catch2 version of the library works properly. It also bumps infra to include a workaround in use-fetch-content.cmake that allows catch2 to be usable from FetchContent_MakeAvailable without needing to include the workaround in the library's CMake itself. Fixes #311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows cookiecutter to support creating Beman libraries that use catch2 as their unit testing library instead of gtest.
It adds a new unit_test_library option to the exemplar cookiecutter parameters that can be set to either "gtest" or "catch2".
It adds a new exemplar-only CI workflow, catch2_exemplar_test.yml, that smoke tests that the catch2 version of the library works properly.
It also bumps infra to include a workaround in use-fetch-content.cmake that allows catch2 to be usable from FetchContent_MakeAvailable without needing to include the workaround in the library's CMake itself.
Fixes #311