Skip to content

VERIFY_INTERFACE_HEADER_SETS only if PROJECT_IS_TOP_LEVEL#303

Merged
ednolan merged 1 commit intobemanproject:mainfrom
ClausKlein:feature/VERIFY_INTERFACE_HEADER_SETS-if-PROJECT_IS_TOP_LEVEL
Mar 14, 2026
Merged

VERIFY_INTERFACE_HEADER_SETS only if PROJECT_IS_TOP_LEVEL#303
ednolan merged 1 commit intobemanproject:mainfrom
ClausKlein:feature/VERIFY_INTERFACE_HEADER_SETS-if-PROJECT_IS_TOP_LEVEL

Conversation

@ClausKlein
Copy link
Copy Markdown
Contributor

@ClausKlein ClausKlein commented Feb 23, 2026 •
edited
Loading

see targets list of ninja help on beman.net project:

beman.execution: phony
beman.execution_headers: phony
beman.execution_headers_verify_interface_header_sets: phony
beman.net_headers: phony
beman.net_headers_verify_interface_header_sets: phony
beman.task: phony
beman.task_headers: phony
beman.task_headers_verify_interface_header_sets: phony
libbeman.execution.a: phony
libbeman.task.a: phony
sorted_list.pass: phony

see https://discourse.bemanproject.org/t/the-verify-interface-header-sets-must-not-always-enabled/560

@ClausKlein ClausKlein self-assigned this Feb 23, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 23, 2026 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 7531ed9 on ClausKlein:feature/VERIFY_INTERFACE_HEADER_SETS-if-PROJECT_IS_TOP_LEVEL
into 89266c7 on bemanproject:main.

@steve-downey
Copy link
Copy Markdown
Member

steve-downey commented Feb 23, 2026

Do we exclude the verification from the alltarget?

@ClausKlein
Copy link
Copy Markdown
Contributor Author

ClausKlein commented Feb 23, 2026

Do we exclude the verification from the alltarget?

It was always an independent target

@ednolan ednolan force-pushed the feature/VERIFY_INTERFACE_HEADER_SETS-if-PROJECT_IS_TOP_LEVEL branch from d180110 to 7531ed9 Compare March 14, 2026 21:28
@ednolan ednolan merged commit 3e83bfa into bemanproject:main Mar 14, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steve-downey steve-downey steve-downey approved these changes

@ednolan ednolan Awaiting requested review from ednolan ednolan is a code owner

@bretbrownjr bretbrownjr Awaiting requested review from bretbrownjr bretbrownjr is a code owner

@camio camio Awaiting requested review from camio camio is a code owner

@dietmarkuehl dietmarkuehl Awaiting requested review from dietmarkuehl dietmarkuehl is a code owner

@neatudarius neatudarius Awaiting requested review from neatudarius

@wusatosi wusatosi Awaiting requested review from wusatosi wusatosi is a code owner

Assignees

@ClausKlein ClausKlein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ClausKlein @coveralls @steve-downey @ednolan