Update CI triggers#28
Merged
bretbrownjr merged 2 commits intobemanproject:mainfrom Sep 25, 2024
Merged
Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
steve-downey
approved these changes
Sep 25, 2024
Member
steve-downey
left a comment
steve-downey
left a comment
There was a problem hiding this comment.
Looks like an improvement to me.
This was referenced Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two requirements for the CI to trigger:
/examplefolder, which doesn't really make sense? We could miss build config update if we need to introduce more configuration files.This PR also introduces nightly build-test (mentioned: #27 (comment) ), the frequency of the periodic update is currently set at daily at 3:30 PM UTC (11:30 ET).
This timestamp and frequency is fairly arbitrary, meant to trigger 30 minutes before the weekly sync call.
The daily build maybe too frequent, this is all open to discussion.