Remove note about omitting CMAKE_PREFIX_PATH#257
Merged
Conversation
This states that if the user has already installed a packaged version of `infra/cmake/beman-install-library-config.cmake`, they can omit `-DCMAKE_PREFIX_PATH=./infra/cmake`. However, no such packaged version exists; the only way to use it currently is through the vendored copy, so this note is not useful in practice. We can restore it when `beman-install-library-config` is packaged.
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
Member
Author
|
@nickelpro @bretbrownjr What do you guys think about this change? |
Member
|
I remain skeptical amateurs clock the meaning of these words one way or another, and experts don't need us to explain when or what goes in So I'm pro-removal. |
Member
Author
|
In that case I'm going to merge this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This states that if the user has already installed a packaged version of
infra/cmake/beman-install-library-config.cmake, they can omit-DCMAKE_PREFIX_PATH=./infra/cmake. However, no such packaged version exists; the only way to use it currently is through the vendored copy, so this note is not useful in practice. We can restore it whenbeman-install-library-configis packaged.