Default generation of CMake config packages to ON#245
Merged
bretbrownjr merged 1 commit intobemanproject:mainfrom Sep 10, 2025
Merged
Default generation of CMake config packages to ON#245bretbrownjr merged 1 commit intobemanproject:mainfrom
bretbrownjr merged 1 commit intobemanproject:mainfrom
Conversation
bretbrownjr
commented
Sep 7, 2025
bretbrownjr
force-pushed
the
better-defaults
branch
2 times, most recently
from
be5ac83 to
e23440d
Compare
ednolan
approved these changes
Sep 8, 2025
nickelpro
approved these changes
Sep 8, 2025
Member
nickelpro
left a comment
nickelpro
left a comment
There was a problem hiding this comment.
Same as infra, happy with this in principle. 
when you're happy.
I don't generate exemplar releases so however you want to handle it is good with me. It's tricky-not-impossible to extract in the CI publishing job. Generally I say "don't screw it up" and create a dedicated release commit/tag which bumps the version number only. That commit and its message are the signal to CI to publish a release.
Problem ------- When consuming this project as a package, consumers will receive errors when executing `find_package(beman.exemplar)`. This is because by default the required CMake files are not installed with the package. Solution -------- Bump the version of the infra subdirectory to use a new release of the `beman-install-library` CMake module that provides support for `BEMAN_EXEMPLAR_INSTALL_CONFIG_FILE_PACKAGE` and `BEMAN_INSTALL_CONFIG_FILE_PACKAGES` options. This change is not anticipated to affect `FetchContent` or other kinds of vendored workflows since installation of libraries is primarily a packaging activity. Even in that case, it is harmless to consumers to install CMake modules that are not used. Also included in this change is improvements to the `beman.exemplar` README to note the existence of the `BEMAN_EXEMPLAR_INSTALL_CONFIG_FILE_PACKAGE` option. Documentation in `README.md` was also updated to reflect the new installation behavior for `cmake --workflow --preset [...]` workflows.
bretbrownjr
force-pushed
the
better-defaults
branch
from
e23440d to
19d99a4
Compare
bretbrownjr
requested review from
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When consuming this project as a package, consumers will receive errors when executing
find_package(beman.exemplar). This is because by default the required CMake files are not installed with the package.Solution
Bump the version of the infra subdirectory to use a new release of the
beman-install-libraryCMake module that provides support forBEMAN_EXEMPLAR_INSTALL_CONFIG_FILE_PACKAGEandBEMAN_INSTALL_CONFIG_FILE_PACKAGESoptions.This change is not anticipated to affect
FetchContentor other kinds of vendored workflows since installation of libraries is primarily a packaging activity. Even in that case, it is harmless to consumers to install CMake modules that are not used.Also included in this change is improvements to the
beman.exemplarREADME to note the existence of theBEMAN_EXEMPLAR_INSTALL_CONFIG_FILE_PACKAGEoption.Documentation in
README.mdwas also updated to reflect the new installation behavior forcmake --workflow --preset [...]workflows.