Call beman_install_library#241
Conversation
|
This requires a sync of the infra-vendored files, so this PR cannot merge until https://github.com/bemanproject/infra/pull/171 is merged. CI is not expected to pass until the new infra version is merged so this repo can be updated. |
|
@neatudarius @wusatosi @ednolan What's the process for updating the cookiecutter subdir? Or is everyone just making every change twice, once in jinja and again in the actual exemplar code? |
That is the current process, unfortunately. |
|
Note that the cookiecutter consistency check should probably diff the |
| @@ -1,3 +1,3 @@ | |||
| [beman_submodule] | |||
| remote=https://github.com/bemanproject/infra.git | |||
There was a problem hiding this comment.
By the way, an easier workflow might be that rather than creating pull requests for a feature branch inside github.com/bemanproject/infra, just point remote here to your own fork, and then make sure to point it back to upstream once your fork's changes are upstreamed, before the change to exemplar lands.
There was a problem hiding this comment.
Good point. I'll keep that in mind for next time. Or if I need to rev the beman.infra changes again.
|
I propose we consider the cookiecutter breakage off topic for this PR. It looks like we need more work on the cookiecutter consistency checks, particularly when a |
|
Thanks for the tip about the post-generation hooks, I wasn't aware of that feature. I agree that using that to dedup |
bretbrownjr
force-pushed
the
beman-install-library
branch
3 times, most recently
from
51ff177 to
606208d
Compare
|
Note that this PR uses the rc/beman-install-library release candidate branch from exemplar. If this PR validates fine, we should merge the infra change. Then I'll bump the commit IDs in the In all the pushes above, I did add some README enhancements to address some of @ednolan's concerns. I also squashed some "fix CI comments" commits into the main commit in this branch. |
bretbrownjr
force-pushed
the
beman-install-library
branch
from
606208d to
9e60bcd
Compare
Problem ------- The complexity required per project to configure install logic is too high. It is also too decentralized, making it difficult to improve the various Beman repos packaging logic over time. Solution -------- Call `beman_install_library` instead. This function will provide reusable installation logic based on Beman Standards.
bretbrownjr
force-pushed
the
beman-install-library
branch
from
9e60bcd to
a9b1d77
Compare
Problem ------- These changes cannot be evaluated without corresponding changes to the infra/ subdir. Solution -------- The corresponding changes were released to github.com/beman-project/infra as a release candidate branch. Set the SHA for the HEAD commit of that branch in the `infra/.beman-submodule` file. Then run the `beman-submodule update` command.
bretbrownjr
force-pushed
the
beman-install-library
branch
from
a9b1d77 to
0218afe
Compare
bretbrownjr
requested review from
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
|
The matching |
3 participants
Problem
The complexity required per project to configure install logic is too high. It is also too decentralized, making it difficult to improve the various Beman repos packaging logic over time.
Solution
Call
beman_install_libraryinstead. This function will provide reusable installation logic based on Beman Standards.