Skip to content

Apply RELEASE.GODBOLT_TRUNK_VERSION#235

Merged
neatudarius merged 2 commits intomainfrom
apply-RELEASE.GODBOLT_TRUNK_VERSION
Jul 22, 2025
Merged

Apply RELEASE.GODBOLT_TRUNK_VERSION#235
neatudarius merged 2 commits intomainfrom
apply-RELEASE.GODBOLT_TRUNK_VERSION

Conversation

@neatudarius
Copy link
Copy Markdown
Member

@neatudarius neatudarius commented Jul 19, 2025 •
edited
Loading

Making sure exemplar is green with latest beman-tidy version:
image

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 19, 2025 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 0a6a267 on apply-RELEASE.GODBOLT_TRUNK_VERSION
into 2f18d9d on main.

@neatudarius neatudarius force-pushed the apply-RELEASE.GODBOLT_TRUNK_VERSION branch 2 times, most recently from f01e934 to 6f6aae9 Compare July 20, 2025 00:00
@JeffGarland
Copy link
Copy Markdown
Member

JeffGarland commented Jul 20, 2025

698 files changed! oh no....

@neatudarius neatudarius force-pushed the apply-RELEASE.GODBOLT_TRUNK_VERSION branch from 6f6aae9 to 2ba244e Compare July 20, 2025 00:02
@JeffGarland
Copy link
Copy Markdown
Member

JeffGarland commented Jul 20, 2025

so is it possible to say 'SKIPPED' instead of ERROR/ WARNING on the output from tidy? As a user it's confusing that the tool is telling me there's an ERROR and then the check passes...

@neatudarius
Copy link
Copy Markdown
Member Author

neatudarius commented Jul 20, 2025

698 files changed! oh no....

It was a mistake, I added a build venv directory.. removed.

@neatudarius
Copy link
Copy Markdown
Member Author

neatudarius commented Jul 20, 2025 •
edited
Loading

@ednolan , what should I put as a placeholder for that link? https://github.com/bemanproject/exemplar/actions/runs/16394014987/job/46323682814?pr=235

I would like to have a broken link into generated repo, because beman-tidy will detect if the suffix is not [a-zA-Z0-9]+ matched. I also tried with TODO_REPLACE_ME.

@neatudarius neatudarius marked this pull request as ready for review July 20, 2025 00:06
JeffGarland
JeffGarland reviewed Jul 20, 2025
View reviewed changes
Comment thread cookiecutter/{{cookiecutter.project_name}}/README.md Outdated
@neatudarius
Copy link
Copy Markdown
Member Author

neatudarius commented Jul 20, 2025 •
edited
Loading

so is it possible to say 'SKIPPED' instead of ERROR/ WARNING on the output from tidy? As a user it's confusing that the tool is telling me there's an ERROR and then the check passes...

I'll do that in https://github.com/bemanproject/infra/issues/147. @JeffGarland , thanks for suggestion!

@ednolan
Copy link
Copy Markdown
Member

ednolan commented Jul 20, 2025 •
edited
Loading

I would like to have a broken link into generated repo, because beman-tidy will detect if the suffix is not [a-zA-Z0-9]+ matched. I also tried with TODO_REPLACE_ME.

Our current CI system for cookiecutter won't support this, because it will fail if the output of cookiecutter does not exactly match exemplar.

EDIT: See thread here: #235 (comment)

neatudarius
neatudarius commented Jul 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (for what Eddie pushed on this branch).

@neatudarius neatudarius mentioned this pull request Jul 20, 2025
Merged
@neatudarius
Copy link
Copy Markdown
Member Author

neatudarius commented Jul 20, 2025 •
edited
Loading

Please approve, but DO NOT merge this PR! I will do it after testing https://github.com/bemanproject/infra/pull/150#issuecomment-3094421806.

CC: @JeffGarland @ednolan

@neatudarius
Copy link
Copy Markdown
Member Author

neatudarius commented Jul 22, 2025

I will merge this since 24h passed, and also it's a commit proposed by @ednolan , and we are 2 agreeing with that.
I need exemplar to be beman-tidy gree for this issue - https://github.com/bemanproject/infra/issues/149

@neatudarius neatudarius merged commit abf4dee into main Jul 22, 2025
86 checks passed
@neatudarius neatudarius deleted the apply-RELEASE.GODBOLT_TRUNK_VERSION branch July 22, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffGarland JeffGarland JeffGarland left review comments

@ednolan ednolan Awaiting requested review from ednolan ednolan is a code owner

@bretbrownjr bretbrownjr Awaiting requested review from bretbrownjr bretbrownjr is a code owner

@camio camio Awaiting requested review from camio camio is a code owner

@dietmarkuehl dietmarkuehl Awaiting requested review from dietmarkuehl dietmarkuehl is a code owner

@steve-downey steve-downey Awaiting requested review from steve-downey steve-downey is a code owner

@wusatosi wusatosi Awaiting requested review from wusatosi wusatosi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neatudarius @coveralls @JeffGarland @ednolan @syajyalfath36-sys