Update README#232
Merged
JeffGarland merged 3 commits intobemanproject:mainfrom Jul 21, 2025
Merged
Conversation
wermos
requested review from
bretbrownjr,
camio,
dietmarkuehl,
ednolan,
neatudarius,
steve-downey and
wusatosi
as code owners
steve-downey
approved these changes
Jul 19, 2025
Contributor
Author
|
There are a couple of suggestions that I didn't incorporate:
And there are a couple of suggestions that I modified a little:
> [!TIP]
> Because this project requires GoogleTest for running tests,
> disabling `BEMAN_EXEMPLAR_BUILD_TESTS` avoids the project from
> cloning GoogleTest from GitHub.
Also, the last subsection still has a little bit of jank, but I didn't know how to fix it so I left it as it is. |
ednolan
approved these changes
Jul 19, 2025
neatudarius
approved these changes
Jul 19, 2025
JeffGarland
reviewed
Jul 20, 2025
ednolan
approved these changes
Jul 20, 2025
Member
|
Thanks @wermos! Merging this request. |
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #182 by updating the relevant CMake command.
I also took the liberty of addressing #139. Even though the issue is already assigned, there has been no work on it since its creation, so I decided to kill two birds with one PR.