Add bemanproject/infra-workflows as beman-submodule#216
Merged
Conversation
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
ednolan
force-pushed
the
enolan_workflowmodule1
branch
from
8c55964 to
0aa7814
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ednolan
force-pushed
the
enolan_workflowmodule1
branch
from
0aa7814 to
3aafd0b
Compare
Since infra commit 1ed1ad5d8c02db1b4d1c93a60b9f87682be080f4, beman submodules can occupy a subdirectory along with other files. This allows us to include the files from the bemanproject/infra-workflows repository as a beman-submodule inside the .github/workflows directory. This approach is needed because of limitations of GitHub Actions. We can't symlink the reusable workflow files into the existing infra beman submodule because GitHub Actions won't follow symlinks, and we can't create a subdirectory for infra-workflows inside .github/workflows because GitHub Actions forbids putting workflow files inside subdirectories.
ednolan
force-pushed
the
enolan_workflowmodule1
branch
from
3aafd0b to
b42e1d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new beman-submodule repository allows us to reuse GitHub Actions workflows between multiple beman projects while maintaining a single source of truth to prevent them from getting out of sync.
Ideally, these would live inside the infra/ repository and be symlinked into the .github directory, but GitHub Actions does not follow symlinks, necessitating a separate repository.