Conversation
…ory of cookiecutter output
Normally, the CI check for cookiecutter attempts to ensure that the
string "exemplar" doesn't appear in the cookiecutter output in order
to verify that the maintainer didn't miss a template.
However, there are uses of that string for unrelated reasons in
infra/, for example:
Untemplated "exemplar" in cookiecutter:
/tmp/tmp.HlSzWR1S2v/RLZrmX9NfS/infra/tools/beman-tidy/beman_tidy/lib/utils/string.py- return name[:6] == "beman." and is_snake_case(name[6:]) and not re.match(".*[0-9]+$", name[6:])
/tmp/tmp.HlSzWR1S2v/RLZrmX9NfS/infra/tools/beman-tidy/beman_tidy/lib/utils/string.py-
/tmp/tmp.HlSzWR1S2v/RLZrmX9NfS/infra/tools/beman-tidy/beman_tidy/lib/utils/string.py-
/tmp/tmp.HlSzWR1S2v/RLZrmX9NfS/infra/tools/beman-tidy/beman_tidy/lib/utils/string.py-def match_badges(string):
/tmp/tmp.HlSzWR1S2v/RLZrmX9NfS/infra/tools/beman-tidy/beman_tidy/lib/utils/string.py- """
/tmp/tmp.HlSzWR1S2v/RLZrmX9NfS/infra/tools/beman-tidy/beman_tidy/lib/utils/string.py: e.g.,   
This commit addresses the issue by removing the "infra" directory
before performing the check.
ednolan
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, the CI check for cookiecutter attempts to ensure that the string "exemplar" doesn't appear in the cookiecutter output in order to verify that the maintainer didn't miss a template.
However, there are uses of that string for unrelated reasons in infra/, for example:
This commit addresses the issue by removing the "infra" directory before performing the check.