Revert complications voided by #142#160
Merged
wusatosi merged 2 commits intobemanproject:mainfrom May 5, 2025
Merged
Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
camio
approved these changes
May 5, 2025
neatudarius
approved these changes
May 5, 2025
ednolan
reviewed
May 5, 2025
| run: | | ||
| sudo add-apt-repository universe | ||
| sudo apt-get update | ||
| sudo apt-get install -y libgtest-dev |
Member
There was a problem hiding this comment.
This seems to be a drive-by fix related to the fact that the ci images now contain libgtest-dev; this is a nitpick, but I think this line should have been in a separate pull request.
Member
Author
There was a problem hiding this comment.
This line is introduced by #105 to support default find package workflow.
#142 essentially set back default workflow to fetch content again.
I see your perspective, we should re-evaluate this later. I don't know if we want to put libgtest-dev in the testing environment without explicitly installing it in a separate step.
Thanks for double checking!
Member
There was a problem hiding this comment.
Oh okay, I didn't understand that. Disregard my comment, in that case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert CI changes introduced in #105, this is possible because we have fix preset regression in #142 .
Related Issues
See also: #141
Motivation and Context
Simplify CI.
Testing
CI passing.
Meta