Refactor ci#159
Merged
wusatosi merged 7 commits intobemanproject:mainfrom May 8, 2025
Merged
Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
camio
approved these changes
May 5, 2025
neatudarius
approved these changes
May 5, 2025
wusatosi
commented
May 6, 2025
| -S . \ | ||
| -DCMAKE_CXX_STANDARD=${{ inputs.cpp_version }} \ | ||
| -DCMAKE_TOOLCHAIN_FILE="${{ inputs.toolchain_file }}" \ | ||
| -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES="./cmake/use-fetch-content.cmake" \ |
Member
Author
There was a problem hiding this comment.
We should take this line out when the packaging alternative is setup.
Member
Author
|
@bretbrownjr can you take a look at this PR? While this is not reuseable workflow, this does extract common steps. I am expecting to extract the environment setup in another PR when the testing container is up. |
Member
Author
|
I will merge this first, @bretbrownjr you can always leave review comments once you have time to look through this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify main build-and-test CI pipeline by extracting CMake invocation as a separate module.
Motivation and Context
This is to prepare for the infra repo, we can ship in this CMake invocation as a standalone GitHub action package or using symlink with git submodule (see: #158 )
Testing
CI passing.
Meta