Conversation
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
linusboehm
approved these changes
Mar 31, 2025
Contributor
linusboehm
left a comment
linusboehm
left a comment
There was a problem hiding this comment.
compile commands was generated as expected.
lgtm
camio
approved these changes
Mar 31, 2025
Member
Reminder - CC @wusatosi |
Member
Author
See:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggested by @linusboehm and agreed on Mar 31th meeting, we add export compile command to CMake preset.
compile_commands.jsonis in top level ignore file already.Basis:
Testing
When running any presets, a
compile_command.jsonwould appear under the build directory.Meta