Apply the latest Beman Standard#15
Merged
camio merged 17 commits intobemanproject:mainfrom Sep 10, 2024
Merged
Conversation
neatudarius
commented
Jul 25, 2024
a877c2e to
81ddf5d
Compare
9b8c5c3 to
1d53fb4
Compare
neatudarius
commented
Aug 14, 2024
2fd7687 to
0df2d52
Compare
a78b5c4 to
9913686
Compare
9913686 to
03cbf60
Compare
neatudarius
commented
Sep 3, 2024
neatudarius
commented
Sep 3, 2024
camio
reviewed
Sep 9, 2024
Member
camio
left a comment
There was a problem hiding this comment.
I wasn't able to add suggestions for the file and directory names, but those should be updated as well.
ec6bbc3 to
831f771
Compare
831f771 to
a0381d1
Compare
camio
approved these changes
Sep 10, 2024
Member
camio
left a comment
There was a problem hiding this comment.
Aside from the TODOs, which can easily be converted into issues against this repository, and a minor issue, this looks good to merge to me.
| if(BUILD_TESTING) | ||
| include(GoogleTest) | ||
|
|
||
| add_executable(beman.example.tests) |
Member
There was a problem hiding this comment.
Should the target name be beman.example.tests.identity in case there are multiple test drivers?
wusatosi
reviewed
Oct 15, 2024
Comment on lines
-33
to
-37
| - { id: ubuntu-gcc-static-cxx98, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=98 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
| - { id: ubuntu-gcc-static-cxx11, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=11 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
| - { id: ubuntu-gcc-static-cxx14, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=14 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
| - { id: ubuntu-gcc-static-cxx17, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
| - { id: ubuntu-gcc-static-cxx20, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=20 -DCMAKE_CXX_STANDARD_REQUIRED=on"} |
Member
There was a problem hiding this comment.
Extend compiler / standard versions for build and run on CI: {gcc, clang} x {C++98, C++03, C++11, C++14, C++17, C++20, 'C++23, C++26}.
Is removing CI testing for C++98 <-> C++17 here intentional?
There's only C++20 <-> C++26 testing left.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the Beman Standard to Beman.Example and more tweaks.
Issues:
Updates related to the Beman Standard:
LICENSE.APACHE_LLVM: Switch from MIT toApache License v2.0 with LLVM Exceptions.LICENSE.CRITERIA: already appliedLICENSE.APPROVED: already appliedFILE.COPYRIGHTLIBRARY_NAMES:REPOSITORY_NAME: renamed toExample(docs + github)TOPLEVEL.CMAKE: already applied (rootCMakeLists.txt, using Ctest)TOPLEVEL.LICENSE: renamed file toLICENCE.TOPLEVEL.READMEREADME.TITLEREADME.PURPOSEREADME.IMPLEMENTSCMAKE.DEFAULTCMAKE.SKIP_TESTSCMAKE.AVOID_PASSTHROUGHSDIRECTORY.INTERFACE_HEADERS:$ tree include include └── Beman └── Example └── example.hppDIRECTORY.IMPLEMENTATION_HEADERS: currently N/ADIRECTORY.SOURCES:$ tree src src └── Beman └── Example ├── CMakeLists.txt ├── example.cpp └── tests ├── CMakeLists.txt └── example.t.cpp 4 directories, 4 filesUpdates related to docs and usage example:
beman::example::identityequivalent of std::identitysrc/Beman/Example/tests/example.t.cpp.examples/sample_usage.cpp.Updates related to CI/infrastructure/other missing bits:
gcc,clang}x {C++98,C++03,C++11,C++14,C++17,C++20, 'C++23,C++26}..gitignore.github/CODEOWNERS